Sindhoor Tilak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43000 )
Change subject: post_code: add missing postcode calls ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43000/2/src/arch/x86/bootblock_crt0... File src/arch/x86/bootblock_crt0.S:
https://review.coreboot.org/c/coreboot/+/43000/2/src/arch/x86/bootblock_crt0... PS2, Line 26: mov %eax, %ebx
After post_code, %eax no longer has BIST.
Ack
https://review.coreboot.org/c/coreboot/+/43000/2/src/arch/x86/bootblock_crt0... PS2, Line 48: movd %eax, %mm0
After post_code, %eax no longer has BIST.
Ack
https://review.coreboot.org/c/coreboot/+/43000/2/src/cpu/intel/car/p3/cache_... File src/cpu/intel/car/p3/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/43000/2/src/cpu/intel/car/p3/cache_... PS2, Line 23: post_code(POST_CAR_FIXED_MTRR)
We need %eax == 0 inside this loop. Move after the loop.
Ack
https://review.coreboot.org/c/coreboot/+/43000/2/src/cpu/intel/car/p4-netbur... File src/cpu/intel/car/p4-netburst/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/43000/2/src/cpu/intel/car/p4-netbur... PS2, Line 26: post_code(POST_CAR_FIXED_MTRR)
Move after the loop clear_fixed_mtrr.
Ack