14 Apr
2020
14 Apr
'20
10:47 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40373 )
Change subject: Makefile: Simplify calculation of region base with default fmd files ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40373/1/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40373/1/Makefile.inc@984 PS1, Line 984: endif nit: maybe if you reshuffled this a bit most of these could be shared between x86 and non-x86 now?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a109462928b6e8b7930bbcc1a1ba45fa85de6ac
Gerrit-Change-Number: 40373
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 Apr 2020 20:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment