15 Oct
2020
15 Oct
'20
12:20 a.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46354 )
Change subject: include/cpu/x86: introduce new helper for (un)setting MSRs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46354/3/src/cpu/intel/haswell/final... File src/cpu/intel/haswell/finalize.c:
https://review.coreboot.org/c/coreboot/+/46354/3/src/cpu/intel/haswell/final... PS3, Line 10: (1 << 0) nit: we should use the BIT macro (types.h) more often 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/46354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfe9b66e7cfe78ec295a44a2a193f530349f7689
Gerrit-Change-Number: 46354
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 14 Oct 2020 21:20:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment