Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48844 )
Change subject: mb/google/zork: enable wake on EC MKBP interrupts ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48844/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48844/1//COMMIT_MSG@11 PS1, Line 11: EC_AP_INT_ODL EC_AP_INT_ODL is primarily for sensor interrupts in S0 (if required for tight timestamps). All wakes from EC to host happen via GPIO_24 (EC_FCH_WAKE_L). I don't think we need two wake routes from EC to AP. Instead the appropriate wake mask must be set for the respective host event in MAINBOARD_EC_S3_WAKE_EVENTS.