EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33379 )
Change subject: soc/intel: Provide SPD manufacturer ID and module type to SMBIOS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33379/1/src/soc/intel/apollolake/meminit_uti...
File src/soc/intel/apollolake/meminit_util_apl.c:
https://review.coreboot.org/#/c/33379/1/src/soc/intel/apollolake/meminit_uti...
PS1, Line 98: 0);
Why only APL didn't pass the type? Only support one type?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id673e08aa6e3dad196009c3c21a3dda2f40c9e42
Gerrit-Change-Number: 33379
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 11 Jun 2019 05:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment