Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33142 )
Change subject: Kconfig: Create coreboot separate stage kconfigs ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+1
The other bit to get correct here is removing the root dependencies if these values are not selected. I think if you do that correctly then many of the follow up CLs aren't needed since Make won't try evaluating the rules.
Do you like to club all ENABLE_STAGE_<> related changes into this CL? In that way i believe we will loose traceability
Not necessarily, but as things currently stand this CL doesn't really do anything. We should be plumbing the removal of the root dependencies based on these Kconfigs in this CL, though.
I can club https://review.coreboot.org/c/coreboot/+/33112/3 and https://review.coreboot.org/c/coreboot/+/33116/4 into this if you think that helps to justify things better for this CL.