Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )
Change subject: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY
......................................................................
Patch Set 5:
What does FSP do if we set it to PRIMARY_PCI but there is no
gfx card plugged in?
Also, please note that the two options don't do the same,
ONBOARD_VGA_IS_PRIMARY takes the devicetree into account,
for FSP it's just IGD vs. anything else. I wouldn't mind
some unification in that area, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcd117217cf412ee0722aff52db4b3c8ec2a226c
Gerrit-Change-Number: 39374
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 23 Mar 2020 16:35:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment