Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47172 )
Change subject: soc/intel/xeon_sp: Move set_bios_init_completion() ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47172/1/src/soc/intel/xeon_sp/util.... File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/47172/1/src/soc/intel/xeon_sp/util.... PS1, Line 303: die("BIOS PCU Misc Config Read timed out.\n"); why is die() called here? does something super bad going to happe when continuing here?