Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38278 )
Change subject: mb/google/dedede: Add GPIO stubs
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38278/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38278/5/src/mainboard/google/dedede...
PS5, Line 9: #include <baseboard/gpio.h>
not needed?
Currently the header is empty, but once you start adding things to the header you need to include it.
https://review.coreboot.org/c/coreboot/+/38278/5/src/mainboard/google/dedede...
PS5, Line 13: #include <variant/gpio.h>
not needed?
Currently there are no variants. But once we start adding variants, you need to include it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38278
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1397b6a433e5046650f64f7eb9a84c51eb0c7441
Gerrit-Change-Number: 38278
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 Jan 2020 18:04:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment