Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40377 )
Change subject: coreboot-id: Add coreboot id based on FMAP entries ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/mc_apl_vboot.fmd:
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... PS2, Line 9: COREBOOT_ID 0x40 : RO_FRID_PAD 0x780 I have built this patchset for mc_apl5 which uses a vboot scheme. Here is a hexdump of the related image portion: ***** 00304800 53 69 65 6d 65 6e 73 5f 4d 43 20 41 50 4c 35 2e |Siemens_MC APL5.| 00304810 34 2e 31 31 2d 32 31 39 35 2d 67 63 64 37 32 64 |4.11-2195-gcd72d| 00304820 31 37 63 38 30 00 00 00 00 00 00 00 00 00 00 00 |17c80...........| 00304830 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00304840 34 2e 31 31 2d 32 31 39 35 2d 67 63 64 37 32 64 |4.11-2195-gcd72d| 00304850 31 37 63 38 30 00 53 69 65 6d 65 6e 73 00 4d 43 |17c80.Siemens.MC| 00304860 20 41 50 4c 35 00 ff ff ff ff ff ff ff ff ff ff | APL5...........| ***** Now we do have nearly the same information twice, sitting next to each other in the image. The first part comes from the region RO_FRID while the second one is the new stuff added by your patch. Is this realy needed or should we skip it for VBOOT enabled boards like chromebooks do?