Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40955 )
Change subject: payloads/external/GRUB2: prevent rebuild without actual changes ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40955/1/payloads/external/GRUB2/Mak... File payloads/external/GRUB2/Makefile:
https://review.coreboot.org/c/coreboot/+/40955/1/payloads/external/GRUB2/Mak... PS1, Line 40: grub2: $(CONFIG_DEP) checkout grub2/build/config.h
And I just realized that the dependency of grub2 on `$(obj)/config.h` is already specified in `payloads/external/Makefile.inc` so there is absolutely no need to carry that `CONFIG_DEP` around. Thus, I will drop it, too.
I was a bit too hasty here. While CONFIG_DEP is not *needed* we should still keep it to keep Make from running `grub2` in `payloads/external/Makefile` when there is no change at all. Actually, this does only save us some seconds (no full rebuild gets triggered) but it feels a bit wrong to do something senseless... so let's keep it.