Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46962 )
Change subject: mb/google/hatch/jinlon: Describe the privacy_gpio ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... PS2, Line 86: ACPI_GPIO_INPUT_ACTIVE_LOW
My (limited) understanding is that this is an IRQ, would a GpioInterrupt be more appropriate?
I though that too. but then I had a nice conversation with Andy Shevchenko. If you want to read an irq pin, you have to declare it as GpioIo(), not as GpioInt().
https://lore.kernel.org/linux-gpio/CAHp75Vd7D7gArrgAWJ-e=u-KeGiQ5Ouj94YGfRmL...
https://lore.kernel.org/linux-gpio/CAHp75VdZiOnQdUirEM1BG27kV=htNX95Ar6eJ8LA...
Also there is no way (and kernel upstream do not want) to define a GpioInt() as EDGE and BOTH and ACTIVE_LOW().