Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31917 )
Change subject: soc/intel/cnl: Generate DMAR ACPI table
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/#/c/31917/15/src/soc/intel/cannonlake/acpi.c
File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/#/c/31917/15/src/soc/intel/cannonlake/acpi.c@355
PS15, Line 355: !(MCHBAR32(VTVC0BAR) & VTBAR_ENABLED))
The early code always sets this bit if the chipset is capable.
If this should stay as a way to check if FSP overrode this choice,
please add a comment.
But I'd actually prefer that we force any VtdDisable UPD to 0,
to make sure that this doesn't happen.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e1ee5244c67affb13947436d81628c5dc665c9e
Gerrit-Change-Number: 31917
Gerrit-PatchSet: 15
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Assignee: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 19:18:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment