Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4 ......................................................................
Patch Set 10:
(3 comments)
Some late comments I forgot to send. Nothing serious.
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... PS9, Line 103: child_res->limit && Why? doesn't it cover up errors?
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... PS9, Line 271: resource->flags |= IORESOURCE_ASSIGNED; Not clearing IORESOURCE_STORED means we must be called with all non-fixed resources without it set. The old behavior seemed correct.
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... PS9, Line 333: 0x3df Last parameter is the size.