Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42517 )
Change subject: soc/amd/picasso/uart: factor out console-related functions
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42517/3/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/uart.h:
https://review.coreboot.org/c/coreboot/+/42517/3/src/soc/amd/picasso/include...
PS3, Line 7: void clear_uart_legacy_config(void);
Add some commentary for thefunctions?
Done
https://review.coreboot.org/c/coreboot/+/42517/3/src/soc/amd/picasso/include...
PS3, Line 9: uintptr_t
#include headers that provide the types you are using.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56911addc8c000a0772156e5166720867cdd26fe
Gerrit-Change-Number: 42517
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Jun 2020 16:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment