Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38155 )
Change subject: soc/intel/{cnl,icl,tgl}: Move northbridge.asl into common/block/acpi
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38155/5/src/mainboard/google/dragon...
File src/mainboard/google/dragonegg/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38155/5/src/mainboard/google/dragon...
PS5, Line 40: #include <soc/intel/common/block/acpi/acpi/northbridge.asl>
Incase of #if case then should't we also have to use something for #else ? But in this case there is […]
I think main purpose of this patch is using common file to reduce duplicated asl file in each soc folder. Sp if we use compile condition, we need to keep duplicated asl file even if we use common asl file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38155
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9af844bcbbcce3f4b0ac7aada43d43e4171e08b
Gerrit-Change-Number: 38155
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Wed, 08 Jan 2020 05:43:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment