Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject wake polarity
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/33427/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/#/c/33427/2/src/mainboard/google/hatch/variants/...
PS2, Line 99: EV_ACT_DEASSERTED
Is this true for helios as well? i.e. similar polarity?
https://review.coreboot.org/#/c/33427/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/#/c/33427/2/src/mainboard/google/hatch/variants/...
PS2, Line 91: EV_ACT_DEASSERTED
... and kindred too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0816ed9fb23cf00fd8e40bcdd25ff7a9f48badbd
Gerrit-Change-Number: 33427
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:35:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
