Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39390 )
Change subject: cbfstool: Build vboot library ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39390/7/.gitignore File .gitignore:
https://review.coreboot.org/c/coreboot/+/39390/7/.gitignore@55 PS7, Line 55: vboot_lib/
Isn't this under build/ (and therefore already excluded)?
That's true for top-most make and futility. However, when running 'make' inside util/cbfstool, the binaries will be inside util/cbfstool/vboot_lib.
https://review.coreboot.org/c/coreboot/+/39390/7/Makefile File Makefile:
https://review.coreboot.org/c/coreboot/+/39390/7/Makefile@45 PS7, Line 45: VBOOT_BUILD
Probably better to name it VBOOT_HOST_BUILD or something to make it clear that this is separate from […]
Do you mean to rename this variable for futility as well? When running make from the top-level Makefile, VBOOT_BUILD will be passed to both cbfstool/Makefile.inc and futility/Makefile.inc so that *.o files can be reused.
https://review.coreboot.org/c/coreboot/+/39390/7/util/cbfstool/Makefile.inc File util/cbfstool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39390/7/util/cbfstool/Makefile.inc@... PS7, Line 135: VBOOTCFLAGS += -Wno-missing-field-initializers
You probably want to mirror what futility does here (unset CFLAGS LDFLAGS; and let vboot figure it o […]
Done