EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38665 )
Change subject: mb/google/drallion: Use GPP_D15 as touch reset pin
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38665/1/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38665/1/src/mainboard/google/dralli...
PS1, Line 344: register "generic.stop_delay_ms" = "10"
Oh, this stop delay is miss. I will recover it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38665
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7eb78a05e653f271e348ed11f7e31c08bd5dc
Gerrit-Change-Number: 38665
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 01 Feb 2020 17:06:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment