Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32352 )
Change subject: configs: add Lenovo G505S sample configuration (use with dGPU patches) ......................................................................
Patch Set 9:
(1 comment)
Patch Set 5:
Patch Set 5:
Use make savedefconfig to generate config files.
Would it work as good as this full .config? (no further questions should be asked about config during the beginning of make command)
P.S. Thank you very much for reviewing CB:31448 , will check it in more detail soon
yes. "cp defconfig .config; make olddefconfig" should work. Using full configfiles is not a good idea as coreboot is a moving target, with generally sane defaults which don't get set when you have a full config file.
https://review.coreboot.org/#/c/32352/6/configs/config.lenovo_g505s_use_with... File configs/config.lenovo_g505s_use_with_dgpu_patches:
https://review.coreboot.org/#/c/32352/6/configs/config.lenovo_g505s_use_with... PS6, Line 5: VGA_BIOS=y Adding blobs is never a coreboot default.