Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33406 )
Change subject: util/superiotool: added NCT5539D chip registers
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/33406/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33406/4//COMMIT_MSG@7
PS4, Line 7: util/superiotool: added NCT5539D chip registers
Please use present tense (and imperative mood):
Add NCT5539D chip registers
https://review.coreboot.org/#/c/33406/4//COMMIT_MSG@8
PS4, Line 8:
Please mention the data sheet name and version in the commit message.
On what board did you test this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33406
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dbcc1c5514b96ddf63a5ab2cb263f5f17002389
Gerrit-Change-Number: 33406
Gerrit-PatchSet: 4
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Jun 2019 07:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment