Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco...
PS2, Line 10: SOC_INTEL_JASPERLAKE
Not all PCH IPs under PCH_BASE apply for JSL
Ok. I too checked again the PCH base does apply to JSL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5001dc498a7d7d5c7903dc3a3762da740fc9c8e
Gerrit-Change-Number: 37112
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 24 Nov 2019 07:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment