build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48163 )
Change subject: lenovo/g505s: add the PIRQ routing table ......................................................................
Patch Set 9:
(15 comments)
File src/mainboard/lenovo/g505s/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/d7fb0f7e_cccbecbf PS9, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/9047f1ad_fb6b2158 PS9, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/32b486b0_1489a2a7 PS9, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/f2a7b5c3_86051d40 PS9, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/28df7bf5_ca0346db PS9, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/6ed4b6cd_edd8a6a6 PS9, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/7fecc700_a9372f2c PS9, Line 35: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/c6976f51_2e0fef5e PS9, Line 37: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/1c09a9bb_c4454362 PS9, Line 40: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/06ec04a8_bdcab19f PS9, Line 43: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/bc3d1cf4_103a9439 PS9, Line 46: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/a7299a85_206396b8 PS9, Line 49: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/e227ee3b_8753103d PS9, Line 51: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x1, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/6fbdc48b_ad06ecf9 PS9, Line 53: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x2, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131808): https://review.coreboot.org/c/coreboot/+/48163/comment/ffbb6040_0356382d PS9, Line 55: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90}, {0x01, 0xdc90} }, 0x3, 0x0} line over 96 characters