Attention is currently required from: Nico Huber, Krishna Prabhakaran, Furquan Shaikh, Maulik V Vaghela, Selma Bensaid, Subrata Banik, Patrick Rudolph.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1
......................................................................
Patch Set 13:
(1 comment)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52758/comment/830b70c4_4c6052c7
PS13, Line 105: INTEL_GMA_OPREGION_2_0
Is there a reason why some platforms would want to use version 2.0? Can we move all platforms to 2. […]
I believe that we would need support for 2.0 since all the earlier platforms like cml,jsl and tgl uses 2.0.
However, we can make 2.1 as default but we would need a change in soc kconfigs of all earlier platforms. Would that be recommended?
Only adl uses 2.1 as of now and one kconfig change would suffice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b
Gerrit-Change-Number: 52758
Gerrit-PatchSet: 13
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 08 Jul 2021 06:34:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment