Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44165 )
Change subject: superio/ite: configure EC for fans to full at thermal limit
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44165/1/src/superio/ite/common/env_...
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/44165/1/src/superio/ite/common/env_...
PS1, Line 151: ITE_EC_FAN_CTL_FULL_AT_THRML_LMT(conf->full_lmt));
Ouch. The OR way sounds good. […]
That commit would be CB:42134 which is on permanent hold because people want me to ask on the mailing list about introducing new naming conventions (and which I'm not going to do because I kind of gave up on that patch series)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie74102ac0d54be33558c161c9c84594d121772b1
Gerrit-Change-Number: 44165
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 22:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Büchler
michael.buechler@posteo.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment
