Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42403 )
Change subject: mb/asrock/b85m_pro4: Properly select muxed functions ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42403/10/src/mainboard/asrock/b85m_... File src/mainboard/asrock/b85m_pro4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42403/10/src/mainboard/asrock/b85m_... PS10, Line 16: /* Select SIO pin states */
pin mux state? those registers should be about the pin muxing and not that much about the pin states
I copied the comment from P8Z77-V LX2, and I think it's in many other places as well. I'd have to update all instances