Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40017 )
Change subject: soc/amd/common/psp: make BootDone command conditional
......................................................................
Patch Set 3: Code-Review-1
Felix, I guess we need more time to chat :D Actually, I prefer coreboot and the common//psp code always own the communication with the PSP. That means we need to remove it from the FSP instead (or configurable). In the meantime, calling both ought not harm anything except the 2nd one will be ignored. I think you can abandon this patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I819ab0b80d2a3cf6cd24f3e7170cae779dcc7cef
Gerrit-Change-Number: 40017
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Apr 2020 18:07:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment