Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31527 )
Change subject: cpu/x86/mtrr/mtrr.c:Avoid static scan false positive
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31527/1/src/cpu/x86/mtrr/mtrr.c
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/#/c/31527/1/src/cpu/x86/mtrr/mtrr.c@335
PS1, Line 335:
If you could fix this. Excluding vendorcode, the only location with spaces after assert is in src/northbridge/amd/amdht/h3finit.c
$ git grep 'ASSERT (' | grep -v vendorcode
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec0ac432c745bde4b1700539c266625da6cfd77
Gerrit-Change-Number: 31527
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Feb 2019 19:00:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment