Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37455 )
Change subject: libpayload/drivers/i8042: If configured ignore all i8042 init failures
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37455/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37455/1/payloads/libpayload/drivers...
PS1, Line 348: 0xf6
I changed my commit message to make it clear that this is cleaning up what was added in CB:23584, I […]
For the future. Git makes it easy to commit small changes, so that should be used. First, it makes review easier as undisputed (trivial) changes can be accepted/submitted very quickly. Second, if your change would be reverted, this undisputed fix would also be reverted, which is unwanted.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1c908b11afb8098a6cbbfa8a3d4391cabacd0f
Gerrit-Change-Number: 37455
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Dec 2019 13:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment