[coreboot-gerrit] Change in coreboot[master]: pcengines/apu2: Switch away from ROMCC_BOOTBLOCK

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36915 )

Change subject: pcengines/apu2: Switch away from ROMCC_BOOTBLOCK
......................................................................

Patch Set 35:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36915/30/src/mainboard/pcengines/ap... 
File src/mainboard/pcengines/apu2/romstage.c:

https://review.coreboot.org/c/coreboot/+/36915/30/src/mainboard/pcengines/ap... 
PS30, Line 66: 	pci_write_config32(dev, LPC_IO_OR_MEM_DECODE_ENABLE, data | 3);
> LPC_IO_PORT_DECODE_ENABLE […]

This is my bad. I should abstract the SIO LPC decode into hudson_sio_decode_enable() and TPM
addresses/ports decoding into hudson_tpm_decode_enable(). I will push a patch for that.

I understand the use-case and it is generally a nice idea.

There should be very little cases where LPC shouldn't be enabled. I think LPC could be enabled by default always. Anything against that idea?