Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30998 )
Change subject: soc/amd/stoneyridge/gpio: Allow specifying 0 value for debounce timeout
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30998/1/src/soc/amd/stoneyridge/include/soc/...
File src/soc/amd/stoneyridge/include/soc/gpio.h:
https://review.coreboot.org/#/c/30998/1/src/soc/amd/stoneyridge/include/soc/...
PS1, Line 465: #define GPIO_IN_DEBOUNCE_DISABLED (0 | GPIO_TIMEBASE_61uS)
"just 0" would (silently) imply GPIO_TIMEBASE_61uS, which is just one of 4 possible "zeros". […]
sgtm
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9de61297b0677cc904535a51c16970eecb52021d
Gerrit-Change-Number: 30998
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Jan 2019 19:04:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment