25 Nov
2019
25 Nov
'19
8:38 p.m.
Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36830 )
Change subject: sc7180: Add I2C driver ......................................................................
Patch Set 4:
(1 comment)
Patch Set 4: Code-Review+2
(1 comment)
Done, share patch with Mike
https://review.coreboot.org/c/coreboot/+/36830/4/src/soc/qualcomm/sc7180/i2c... File src/soc/qualcomm/sc7180/i2c.c:
https://review.coreboot.org/c/coreboot/+/36830/4/src/soc/qualcomm/sc7180/i2c... PS4, Line 155: if (seg == NULL || seg->buf == NULL)
nit: should be unnecessary
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/36830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61221ffff8afe5c7ede5abb9e194e242ab0274d8
Gerrit-Change-Number: 36830
Gerrit-PatchSet: 4
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Satya Priya Kakitapalli c_skakit@qualcomm.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 26 Nov 2019 04:38:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment