Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52061 )
Change subject: spd.h: Move `DIMMx` macros to i440bx/raminit.h
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/i440bx/raminit.h:
https://review.coreboot.org/c/coreboot/+/52061/comment/68b635c6_5990db92
PS2, Line 9: /* DIMM SPD addresses */
: #define DIMM0 0x50
:
are dimm addresses common or controller/platform specific? if common, what about defining them at a common place?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52061
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d14849b4fb86d34a841d4a13ee3bbb46f9f71c
Gerrit-Change-Number: 52061
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 03 Apr 2021 20:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment