Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33433 )
Change subject: mainboard/facebook/fbg1701: Configure TC358860 eDP to MIPI controller ......................................................................
Patch Set 16:
(2 comments)
Have upload a new patchset solving the comments on this patchset.
The new patchset: https://review.coreboot.org/c/coreboot/+/33736
https://review.coreboot.org/#/c/33433/15/src/mainboard/facebook/fbg1701/rams... File src/mainboard/facebook/fbg1701/ramstage.c:
https://review.coreboot.org/#/c/33433/15/src/mainboard/facebook/fbg1701/rams... PS15, Line 335: if (cpld_version < 7) : edptable = tc348860_table; : else : edptable = b101uan08_table;
Looks like the TC348860 is a discrete eDP to MIPI DSI converter. […]
All revsions contains the TC348660. Will used LCD Panel type for table name
https://review.coreboot.org/#/c/33433/15/src/mainboard/facebook/fbg1701/rams... PS15, Line 363: 1920
maybe change this comment to the full resolution specification (1920x1200) in a separate patch on to […]
Have removed the comment with resolution. Now only resolution info at top of tables.