Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43131 )
Change subject: post_code: replace die postcodes with die_with_post_code ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43131/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43131/7//COMMIT_MSG@7 PS7, Line 7: post_code: replace die postcodes with die_with_post_code This is not true. This change mainly adds postcode calls in places there were none beforehand. Sure, it might make sense to emit postcodes in most of these situations, but please update the commit summary and message accordingly.
https://review.coreboot.org/c/coreboot/+/43131/7/src/soc/amd/stoneyridge/rom... File src/soc/amd/stoneyridge/romstage.c:
https://review.coreboot.org/c/coreboot/+/43131/7/src/soc/amd/stoneyridge/rom... PS7, Line 114: post_code(0x43); Why is this gone?
https://review.coreboot.org/c/coreboot/+/43131/7/src/soc/amd/stoneyridge/rom... PS7, Line 123: post_code(0x44); Why is this gone?
https://review.coreboot.org/c/coreboot/+/43131/7/src/soc/amd/stoneyridge/rom... PS7, Line 115: die_with_post_code(POST_CBMEM_RECOVER_FAIL, This wasn't dying before