Attention is currently required from: Michał Żygowski. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63490 )
Change subject: mb/msi/ms7d25: add GPIO configuration ......................................................................
Patch Set 17: Verified+1
(15 comments)
File src/mainboard/msi/ms7d25/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/20363365_2d3033fc PS17, Line 136: _PAD_CFG_STRUCT(VGPIO_0, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_BUF(RX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/8ad8a358_b964dcaa PS17, Line 137: _PAD_CFG_STRUCT(VGPIO_4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/42b45cef_34e82735 PS17, Line 138: _PAD_CFG_STRUCT(VGPIO_5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_BUF(RX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/d203b324_caa35abd PS17, Line 143: _PAD_CFG_STRUCT(VGPIO_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_10 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/cd199408_b02bd9e6 PS17, Line 146: _PAD_CFG_STRUCT(VGPIO_13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_13 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/54848e27_a27a2627 PS17, Line 151: _PAD_CFG_STRUCT(VGPIO_22, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_22 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/9c4a7d46_8a71d99d PS17, Line 154: _PAD_CFG_STRUCT(VGPIO_25, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_25 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/5de6a691_4c94bd0c PS17, Line 165: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP), 0), /* VGPIO_USB_0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/e0d95e4c_c26eee88 PS17, Line 166: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP), 0), /* VGPIO_USB_1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/5a010e05_2fe281b2 PS17, Line 167: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP), 0), /* VGPIO_USB_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/96898715_02135de3 PS17, Line 168: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP), 0), /* VGPIO_USB_3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/a8aef56c_ab841932 PS17, Line 169: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_USB_8 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/22226658_7b8c1207 PS17, Line 170: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_USB_9 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/1399c99b_db51bff4 PS17, Line 171: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_USB_10 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150357): https://review.coreboot.org/c/coreboot/+/63490/comment/3773dcaf_a5ddd69a PS17, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_USB_11 */ line over 96 characters