Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )
Change subject: mb/google/dedede: Add smihandler stub ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/smihandler.c:
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 34:
I haven't enabled the support for ELOG yet. […]
Ack
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 39: __attribute__((weak))
__weak
Done
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 40: variant_sleep_gpio_table(size_t *num)
nit: This might fit on the above line.
Done
https://review.coreboot.org/c/coreboot/+/38280/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/38280/5/src/mainboard/google/dedede... PS5, Line 39: const struct pad_config *__weak variant_sleep_gpio_table(size_t *num)
"foo *__weak bar" should be "foo *__weak bar"
Done