Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47387 )
Change subject: drivers/ipmi: Handle the condition when (dev->chip_info == NULL) ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
dev->chip_info should never be NULL under normal circumstances, though. Trying to work around the problem feels unnecessarily complex. I'd just throw an error and call it a day.
https://review.coreboot.org/c/coreboot/+/47387/1/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/47387/1/src/drivers/ipmi/ipmi_kcs_o... PS1, Line 80: {{ 0, 0, 0 }, 0, 0} Just use a { 0 } initializer.