Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )
Change subject: drivers/vpd: add framework to search VPD in romstage ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34634/8/src/drivers/vpd/vpd_common.... File src/drivers/vpd/vpd_common.c:
https://review.coreboot.org/c/coreboot/+/34634/8/src/drivers/vpd/vpd_common.... PS8, Line 95: vpd_find_common
maybe rename to vpd_find_from_blob, which is more descriptive than find_common.
Done
https://review.coreboot.org/c/coreboot/+/34634/8/src/drivers/vpd/vpd_common.... PS8, Line 116: bufcpy
we don't encourage acronyms in naming unless if it's very well known/trivial. […]
Done
https://review.coreboot.org/c/coreboot/+/34634/8/src/drivers/vpd/vpd_common.... PS8, Line 122: if (size > (string_size + 1)) {
what about […]
Done