Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32346 )
Change subject: [WIP]mb/fujitsu: add Esprimo E900 ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/#/c/32346/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32346/7//COMMIT_MSG@15 PS7, Line 15: SCH5636 There's an available datasheet online, maybe you can try to add support for it once you get video to work?
https://review.coreboot.org/#/c/32346/7//COMMIT_MSG@18 PS7, Line 18: * S3 resume Maybe depends on SuperIO, or DRAM reset gate GPIO is wrong.
https://review.coreboot.org/#/c/32346/7//COMMIT_MSG@19 PS7, Line 19: * PS/2 Should work once proper SuperIO support is added.
https://review.coreboot.org/#/c/32346/7//COMMIT_MSG@20 PS7, Line 20: * Graphics For the iGPU: Currently you don't have libgfxinit hooked up, and the int15 handler for the VBIOS seems to use incorrect parameters (LVDS?). I highly recommend hooking up libgfxinit, check https://review.coreboot.org/c/coreboot/+/21861 as a reference. Not sure of what your board has, but ports can be: DP1, DP2, DP3, HDMI1, HDMI2, HDMI3, Analog. Yes, it says it isn't working, but the patch I linked shows the necessary changes to hook libgfxinit up.
For any external PCIe GPUs: All of your PCIe ports are disabled in the devicetree. Please test which ones should be enabled: enable all of them, put a device on each physical slot and check which device in the devicetree corresponds to that slot, then disable any unused ports.
https://review.coreboot.org/#/c/32346/7/src/mainboard/fujitsu/esprimo_e900/a... File src/mainboard/fujitsu/esprimo_e900/acpi_tables.c:
https://review.coreboot.org/#/c/32346/7/src/mainboard/fujitsu/esprimo_e900/a... PS7, Line 31: // the lid is open by default. : gnvs->lids = 1; Please remove, there's no lid.
https://review.coreboot.org/#/c/32346/7/src/mainboard/fujitsu/esprimo_e900/d... File src/mainboard/fujitsu/esprimo_e900/devicetree.cb:
https://review.coreboot.org/#/c/32346/7/src/mainboard/fujitsu/esprimo_e900/d... PS7, Line 19: device pci 01.0 off end # PCIe Bridge for discrete graphics This is the PEG (PCI Express Graphics) port, it's a x16 port connected to the northbridge (CPU)
https://review.coreboot.org/#/c/32346/7/src/mainboard/fujitsu/esprimo_e900/d... PS7, Line 39: device pci 1c.0 off end # PCIe Port #1 : device pci 1c.1 off end # PCIe Port #2 : device pci 1c.2 off end # PCIe Port #3 : device pci 1c.3 off end # PCIe Port #4 : device pci 1c.4 off end # PCIe Port #5 : device pci 1c.5 off end # PCIe Port #6 : device pci 1c.6 off end # PCIe Port #7 : device pci 1c.7 off end # PCIe Port #8 These are the southbridge PCIe ports.