6 Feb
2023
6 Feb
'23
3:08 a.m.
Attention is currently required from: Jamie Ryu, Sridhar Siricilla, Eric Lai, Usha P.
Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72789 )
Change subject: mb/intel/mtlrvp: Enable ACPI support for Type-C ports ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/72789/comment/7a939c5c_5e3e43f7 PS2, Line 7: use conn1 as mux_conn[1]
how about conn2/3?
Thankyou Eric! My bad I missed during upload as I was testing with mux ports.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72789
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e5957ca7a6c542a64d79b2ceefbed79ead15811
Gerrit-Change-Number: 72789
Gerrit-PatchSet: 3
Gerrit-Owner: Harsha B R harsha.b.r@intel.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Usha P usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-CC: Haribalaraman Ramasubramanian haribalaraman.r@intel.com
Gerrit-Attention: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Attention: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Usha P usha.p@intel.com
Gerrit-Comment-Date: Mon, 06 Feb 2023 03:08:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment