Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43087 )
Change subject: mb/bostentech: Add GBYT4 port
......................................................................
Patch Set 33:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43087/31/src/mainboard/bostentech/g...
File src/mainboard/bostentech/gbyt4/romstage.c:
https://review.coreboot.org/c/coreboot/+/43087/31/src/mainboard/bostentech/g...
PS31, Line 6: #include <soc/mrc_wrapper.h>
only this one is needed now?
romstage.h is also needed as it provides the prototype for mainboard_fill_mrc_params, I removed everything else.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43087
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99ed0c94c3255578151f940ad9b274e6f0816bfe
Gerrit-Change-Number: 43087
Gerrit-PatchSet: 33
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 02 Aug 2020 06:26:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment