build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43744 )
Change subject: nb/intel/haswell: Set up Root Complex topology
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43744/13/src/northbridge/intel/hasw...
File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/43744/13/src/northbridge/intel/hasw...
PS13, Line 70: #define EPBAR64(x) *((volatile u64 *)(DEFAULT_EPBAR + (x)))
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/43744/13/src/northbridge/intel/hasw...
PS13, Line 81: #define DMIBAR64(x) *((volatile u64 *)(DEFAULT_DMIBAR + (x)))
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43744
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2a61706a127bf2b817004a8ec6a723da9826aad
Gerrit-Change-Number: 43744
Gerrit-PatchSet: 13
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 24 Oct 2020 09:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment