Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47154 )
Change subject: mb/google/dedede/variants: Update Power Limit2 minimum value
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG@7
PS1, Line 7: drawcia
Sure, I will add details in the commit message for this.
Ack
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG@9
PS1, Line 9: Update Power Limit2 minimum value to the same as maximum value.
DTT does not throttle PL2 based on temperature thresholds.
Ack
https://review.coreboot.org/c/coreboot/+/47154/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47154/2//COMMIT_MSG@10
PS2, Line 10: baseboard
I meant that boten, waddledee, waddledoo, metaknight, wheelie all use the DTT entry from baseboard […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47154
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ecf1ffcc7871192ebe18eb8c3c3fd3e1193721e
Gerrit-Change-Number: 47154
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 06:24:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment