Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48543 )
Change subject: soc/intel/elkhartlake: Update IRQ routing settings
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48543/2/src/soc/intel/elkhartlake/a...
File src/soc/intel/elkhartlake/acpi/pci_irqs.asl:
https://review.coreboot.org/c/coreboot/+/48543/2/src/soc/intel/elkhartlake/a...
PS2, Line 6: //
Please use one common comment style for a single line comment
/* D31 */ or
/* Device 31 */
This is valid for a lot following comments.
Where possible, could you please use a more describing comment like "PCIe root ports" or the like for device 28?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53feeab81e82c539fa8e39bf90d3f662f75e6d53
Gerrit-Change-Number: 48543
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Dec 2020 05:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment