Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Kapil Porwal, Angel Pons, Eric Lai.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64793 )
Change subject: soc/intel/meteorlake: Refactor bootblock SoC programming code
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/64793/comment/fad61d66_427b900a
PS1, Line 15: bootblock_ioe_die_early_init();
Could we add a short comment why switching the order solves the hang to the commit comment?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64793
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8485b195f77225d8870589ff2e4d3dbdc8931f0a
Gerrit-Change-Number: 64793
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 21:24:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment