Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42576 )
Change subject: mb/asus/p2b: only select HAVE_MP_TABLE for D and DS variant
......................................................................
Patch Set 1: Code-Review-1
Looks like I was late to the game, but this was never an issue.
In line 23 of mb/asus/p2b/Kconfig:
select BASE_ASUS_P2B_D if BOARD_ASUS_P2B_D || BOARD_ASUS_P2B_DS
HAVE_MP_TABLE is only selected if BASE_ASUS_P2B_D is selected, ie. only D and DS variants.
I just ran make olddefconfig on a p3b-f config and *_MP_TABLE is not present in .config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bd6e774f847289a2b51392b72be7cd55fe98c63
Gerrit-Change-Number: 42576
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 21:29:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment