Attention is currently required from: Kyösti Mälkki. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro() ......................................................................
Patch Set 7:
(1 comment)
File src/vendorcode/google/chromeos/gnvs.c:
https://review.coreboot.org/c/coreboot/+/58896/comment/58a1ffa4_4dd17c10 PS7, Line 67: }
I don't know, can you answer on include/bootmode. […]
get_ec_trusted() is about a pin that doesn't always reflect the actual state (it's a latch that's intentionally hard to clear, so it may sometimes show RW when the EC actually jumped back to RO). This field should continue to be sourced by google_ec_running_ro(), if it needs to be here at all.
Does this ACPI table get cleared/rewritten on S3 resume? That's the only reason I could think of why this would need to be here.