Attention is currently required from: Eric Lai, Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik.
David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79794?usp=email )
Change subject: mb/google/byra/var/*: Set WLAN device type back to pci ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79794/comment/132cff5c_65e94dcb : PS1, Line 12:
Why only partially revert it?
Because https://review.coreboot.org/c/coreboot/+/79150 already partially reverted the LAN drivers, and I wanted to follow the example that was already set. I'm fine with a full revert, if you think that's more appropriate.
Patchset:
PS1:
the problem that prompted this change was that the RP04. […]
I'm having difficulty verifying that this change doesn't introduce the same problem. I can't find the entry in the LPI constraint list with or without the change that introduced the issue I'm trying to fix, which leads me to believe I'm not using the right place. Note that I'm working with a pujjo device, and it never had an RP04 block to begin with (only RP01). It's possible that the device was unaffected, but unfortunately, I think it's more likely that I lack the familiarity with the issue to find it. I don't have a copy of Windows to test with (let alone any ability to debug it), unfortunately.
If you could help me out with how I'd be able to see the erroneous entry in the LPI constraint list, I'd be happy to verify whether or not this change reintroduces the issue. I would prefer that even if this change reintroduces the issue that some consideration is given to finding another way to solve the problem of erroneous entries in the LPI constraint list that doesn't break other functionality.