Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39891 )
Change subject: mb/*/*{i440BX}: Move serial init to bootblock ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39891/1/src/mainboard/asus/p3b-f/bo... File src/mainboard/asus/p3b-f/bootblock.c:
https://review.coreboot.org/c/coreboot/+/39891/1/src/mainboard/asus/p3b-f/bo... PS1, Line 21: /* FIXME: The ASUS P3B-F has a Winbond W83977EF, actually. */ Do not duplicate the comment
https://review.coreboot.org/c/coreboot/+/39891/1/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/Kconfig:
https://review.coreboot.org/c/coreboot/+/39891/1/src/northbridge/intel/i440b... PS1, Line 19: You need to guard this. Otherwise, it gets applied everywhere